lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZEaD4ZTfiEALEaSV@smile.fi.intel.com> Date: Mon, 24 Apr 2023 16:28:01 +0300 From: 'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com> To: Jiawen Wu <jiawenwu@...stnetic.com> Cc: netdev@...r.kernel.org, andrew@...n.ch, linux@...linux.org.uk, jarkko.nikula@...ux.intel.com, olteanv@...il.com, hkallweit1@...il.com, linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org, mengyuanlou@...-swift.com Subject: Re: [PATCH net-next v4 2/8] i2c: designware: Add driver support for Wangxun 10Gb NIC On Sun, Apr 23, 2023 at 10:31:09AM +0800, Jiawen Wu wrote: > > > +++ b/include/linux/platform_data/i2c-dw.h > > > > No way we need this in a new code. > > Do I have to rely on OF or ACPI if I need these parameters? > > > > > > +struct dw_i2c_platform_data { > > > + void __iomem *base; > > > > You should use regmap. > > The resource was mapped on the ethernet driver. How do I map it again > with I2C offset? Create a regmap MMIO and pass the pointer to the child driver via existing private members. See how MFD drivers do that, e.g. intel_soc_pmic_*.c. > > > + unsigned int flags; > > > + unsigned int ss_hcnt; > > > + unsigned int ss_lcnt; > > > + unsigned int fs_hcnt; > > > + unsigned int fs_lcnt; > > > > No, use device properties. > > > > > +}; -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists