lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c01a4c59-6668-4ae7-b7cf-54d5a5a7e897@lunn.ch> Date: Mon, 24 Apr 2023 15:47:14 +0200 From: Andrew Lunn <andrew@...n.ch> To: Alexander Stein <alexander.stein@...tq-group.com> Cc: Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Florian Fainelli <f.fainelli@...il.com>, Christian Marangi <ansuelsmth@...il.com>, netdev@...r.kernel.org Subject: Re: [PATCH 1/1] net: phy: Fix reading LED reg property On Mon, Apr 24, 2023 at 03:40:02PM +0200, Alexander Stein wrote: > 'reg' is always encoded in 32 bits, thus it has to be read using the > function with the corresponding bit width. Hi Alexander Is this an endian thing? Does it return the wrong value on big endian systems? I deliberately used of_property_read_u8() because it will perform a range check, and if the value is bigger or smaller than 0-256 it will return an error. Your change does not include such range checks, which i don't like. Andrew
Powered by blists - more mailing lists