netdev - Re: [PATCH net-next v4 3/8] net: txgbe: Register I2C platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230425151644.szqnyqvxpdkoqqb3@intel.intel>
Date:   Tue, 25 Apr 2023 17:16:44 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Andi Shyti <andi.shyti@...nel.org>
Cc:     Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org,
        andrew@...n.ch, linux@...linux.org.uk,
        jarkko.nikula@...ux.intel.com, olteanv@...il.com,
        andriy.shevchenko@...ux.intel.com, hkallweit1@...il.com,
        linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org,
        mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v4 3/8] net: txgbe: Register I2C platform device

On Tue, Apr 25, 2023 at 05:06:19PM +0200, Andi Shyti wrote:
> Hi Jiawen,
> 
> [...]
> 
> > +	ret = txgbe_i2c_register(txgbe);
> > +	if (ret) {
> > +		wx_err(txgbe->wx, "failed to init i2c interface: %d\n", ret);
> > +		goto err_unregister_swnode;
> > +	}
> > +
> >  	return 0;
> > +
> > +err_unregister_swnode:
> > +	software_node_unregister_node_group(txgbe->nodes.group);
> > +
> > +	return ret;
> 
> no need for the goto here... in my opinion it's easier if you put
> software_node_unregister_node_group() under the if and return
> ret.

please... ignore, I see that there are more goto's added in the
next patches.

Andi