netdev - Re: [PATCH net-next] net: phy: drop PHYLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230425150111.1b17b17b@kernel.org>
Date:   Tue, 25 Apr 2023 15:01:11 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Andrew Lunn" <andrew@...n.ch>, "Paolo Abeni" <pabeni@...hat.com>,
        Netdev <netdev@...r.kernel.org>,
        "Heiner Kallweit" <hkallweit1@...il.com>,
        "Russell King" <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>
Subject: Re: [PATCH net-next] net: phy: drop PHYLIB_LEDS knob

On Tue, 25 Apr 2023 22:44:34 +0100 Arnd Bergmann wrote:
> On Tue, Apr 25, 2023, at 22:38, Andrew Lunn wrote:
> >>  
> >> -config PHYLIB_LEDS
> >> -	bool "Support probing LEDs from device tree"  
> >
> > I don't know Kconfig to well, but i think you just need to remove the
> > text, just keep the bool.
> >
> > -       bool "Support probing LEDs from device tree"
> > +       bool  
> 
> Right, that should work, or it can become
> 
>         def_bool y
> 
> or even
> 
>         def_bool OF
> 
> for brevity.

Hm, I think Paolo was concerned that we'd get PHYLIB_LEDS=y if PHYLIB=n
and LEDS_CLASS=n. But that's not possible because the option is in the
"if PHYLIB" section.

Is that right?