netdev - Re: [PATCH net-next 07/12] ice: Accept LAG netdevs in bridge offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e72018ab-cf1f-f50e-b43a-d50068ef5ff2@intel.com>
Date:   Wed, 26 Apr 2023 17:31:48 +0200
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     "Drewek, Wojciech" <wojciech.drewek@...el.com>
CC:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Ertman, David M" <david.m.ertman@...el.com>,
        "michal.swiatkowski@...ux.intel.com" 
        <michal.swiatkowski@...ux.intel.com>,
        "marcin.szycik@...ux.intel.com" <marcin.szycik@...ux.intel.com>,
        "Chmielewski, Pawel" <pawel.chmielewski@...el.com>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
Subject: Re: [PATCH net-next 07/12] ice: Accept LAG netdevs in bridge offloads

From: Wojciech Drewek <wojciech.drewek@...el.com>
Date: Wed, 26 Apr 2023 13:31:17 +0200

> 
> 
>> -----Original Message-----
>> From: Lobakin, Aleksander <aleksander.lobakin@...el.com>
>> Sent: piątek, 21 kwietnia 2023 16:40
>> To: Drewek, Wojciech <wojciech.drewek@...el.com>
>> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Ertman, David M <david.m.ertman@...el.com>;
>> michal.swiatkowski@...ux.intel.com; marcin.szycik@...ux.intel.com; Chmielewski, Pawel <pawel.chmielewski@...el.com>;
>> Samudrala, Sridhar <sridhar.samudrala@...el.com>
>> Subject: Re: [PATCH net-next 07/12] ice: Accept LAG netdevs in bridge offloads
>>
>> From: Wojciech Drewek <wojciech.drewek@...el.com>
>> Date: Mon, 17 Apr 2023 11:34:07 +0200
>>
>>> Allow LAG interfaces to be used in bridge offload using
>>> netif_is_lag_master. In this case, search for ice netdev in
>>> the list of LAG's lower devices.
>>>
>>> Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
>>> ---
>>>  .../net/ethernet/intel/ice/ice_eswitch_br.c   | 40 ++++++++++++++++---
>>>  1 file changed, 35 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch_br.c b/drivers/net/ethernet/intel/ice/ice_eswitch_br.c
>>> index 82b5eb2020cd..49381e4bf62a 100644
>>> --- a/drivers/net/ethernet/intel/ice/ice_eswitch_br.c
>>> +++ b/drivers/net/ethernet/intel/ice/ice_eswitch_br.c
>>> @@ -15,8 +15,21 @@ static const struct rhashtable_params ice_fdb_ht_params = {
>>>
>>>  static bool ice_eswitch_br_is_dev_valid(const struct net_device *dev)
>>>  {
>>> -	/* Accept only PF netdev and PRs */
>>> -	return ice_is_port_repr_netdev(dev) || netif_is_ice(dev);
>>> +	/* Accept only PF netdev, PRs and LAG */
>>> +	return ice_is_port_repr_netdev(dev) || netif_is_ice(dev) ||
>>> +		netif_is_lag_master(dev);
>>
>> Nit: usually we align to `return` (7 spaces), not with one tab:
>>
>> 	return ice_is_port_repr_netdev(dev) || netif_is_ice(dev) ||
>> 	       netif_is_lag_master(dev);
> 
> I've seen examples of both so either way is ok I think

Correct, that's more of my personal :D Or maybe I've seen a couple times
that either checkpatch or something else complained on the second line
being not aligned to the first one with `return`.

[...]

Thanks,
Olek