netdev - RE: [PATCH net-next 06/12] ice: Add guard rule when creating FDB in switchdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR11MB57763D4ECDBA8A57EAF045D9FD6A9@MW4PR11MB5776.namprd11.prod.outlook.com>
Date:   Thu, 27 Apr 2023 07:24:05 +0000
From:   "Drewek, Wojciech" <wojciech.drewek@...el.com>
To:     "Lobakin, Aleksander" <aleksander.lobakin@...el.com>
CC:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Ertman, David M" <david.m.ertman@...el.com>,
        "michal.swiatkowski@...ux.intel.com" 
        <michal.swiatkowski@...ux.intel.com>,
        "marcin.szycik@...ux.intel.com" <marcin.szycik@...ux.intel.com>,
        "Chmielewski, Pawel" <pawel.chmielewski@...el.com>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
Subject: RE: [PATCH net-next 06/12] ice: Add guard rule when creating FDB in
 switchdev



> -----Original Message-----
> From: Lobakin, Aleksander <aleksander.lobakin@...el.com>
> Sent: środa, 26 kwietnia 2023 17:25
> To: Drewek, Wojciech <wojciech.drewek@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Ertman, David M <david.m.ertman@...el.com>;
> michal.swiatkowski@...ux.intel.com; marcin.szycik@...ux.intel.com; Chmielewski, Pawel <pawel.chmielewski@...el.com>;
> Samudrala, Sridhar <sridhar.samudrala@...el.com>
> Subject: Re: [PATCH net-next 06/12] ice: Add guard rule when creating FDB in switchdev
> 
> From: Wojciech Drewek <wojciech.drewek@...el.com>
> Date: Wed, 26 Apr 2023 11:50:56 +0200
> 
> >
> >
> >> -----Original Message-----
> >> From: Drewek, Wojciech
> >> Sent: wtorek, 25 kwietnia 2023 11:18
> >> To: Lobakin, Aleksander <aleksander.lobakin@...el.com>
> 
> [...]
> 
> >>> 	guard_rule = ice_eswitch_...
> >>> 	err = PTR_ERR(guard_rule);
> >>> 	if (err) {
> >>> 		...
> >>>
> >>
> >> I like it, less ptr <-> macros
> >
> > Actually it won't work, PTR_ERR would not convert pointer to 0 in case of success.
> 
> Ooops, PTR_ERR_OR_ZERO() then? I forgot there are several macros for
> different cases =\

Cool, this is what we needed :)

> 
> >
> >>
> >>>> +		dev_err(dev, "Failed to create eswitch bridge %sgress guard rule, err: %d\n",
> >>>> +			port_type == ICE_ESWITCH_BR_UPLINK_PORT ? "e" : "in",
> >>>> +			err);
> >>>
> >>> You still can print it via "%pe" + @guard_rule instead of @err :p (same
> >>> with @fwd_rule above)
> [...]
> 
> Thanks,
> Olek