netdev - Re: [PATCH net] selftests: bonding: delete unnecessary line.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKVySpyXYUDUtA26pA7A0buCW30VNhgn7aYc+cTXbb9PK=F5oA@mail.gmail.com>
Date:   Thu, 27 Apr 2023 15:19:13 +0800
From:   Liang Li <liali@...hat.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>
Cc:     netdev@...r.kernel.org, j.vosburgh@...il.com,
        Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCH net] selftests: bonding: delete unnecessary line.

Thank you! Do I need to re-send a patch?

Regards,
Liang Li

On Thu, Apr 27, 2023 at 2:53 PM Nikolay Aleksandrov <razor@...ckwall.org> wrote:
>
> On 27/04/2023 06:43, Liang Li wrote:
> > "ip link set dev "$devbond1" nomaster"
> > This line code in bond-eth-type-change.sh is unnecessary.
> > Because $devbond1 was not added to any master device.
> >
> > Signed-off-by: Liang Li <liali@...hat.com>
> > Acked-by: Hangbin Liu <liuhangbin@...il.com>
> > ---
> >  .../selftests/drivers/net/bonding/bond-eth-type-change.sh        | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> > index 5cdd22048ba7..862e947e17c7 100755
> > --- a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> > +++ b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> > @@ -53,7 +53,6 @@ bond_test_enslave_type_change()
> >       # restore ARPHRD_ETHER type by enslaving such device
> >       ip link set dev "$devbond2" master "$devbond0"
> >       check_err $? "could not enslave $devbond2 to $devbond0"
> > -     ip link set dev "$devbond1" nomaster
> >
> >       bond_check_flags "$devbond0"
> >
>
> I don't think this is -net material. But either way the patch looks good.
>