netdev - Re: [PATCH net 2/2] net/sched: flower: fix error handler on replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 May 2023 19:44:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Vlad Buslov <vladbu@...dia.com>
Cc: Ivan Vecera <ivecera@...hat.com>, Simon Horman
 <simon.horman@...igine.com>, Pedro Tammela <pctammela@...atatu.com>,
 <davem@...emloft.net>, <netdev@...r.kernel.org>, <jhs@...atatu.com>,
 <xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
 <marcelo.leitner@...il.com>, <paulb@...dia.com>, "Paolo Abeni"
 <pabeni@...hat.com>
Subject: Re: [PATCH net 2/2] net/sched: flower: fix error handler on replace

On Fri, 28 Apr 2023 14:03:19 +0300 Vlad Buslov wrote:
> Note that with these changes (both accepted patch and preceding diff)
> you are exposing filter to dapapath access (datapath looks up filter via
> hash table, not idr) with its handle set to 0 initially and then resent
> while already accessible. After taking a quick look at Paul's
> miss-to-action code it seems that handle value used by datapath is taken
> from struct tcf_exts_miss_cookie_node not from filter directly, so such
> approach likely doesn't break anything existing, but I might have missed
> something.

Did we deadlock in this discussion, or the issue was otherwise fixed?