lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230503195948.08e9ff1d@kernel.org> Date: Wed, 3 May 2023 19:59:48 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Leon Romanovsky <leon@...nel.org> Cc: Ding Hui <dinghui@...gfor.com.cn>, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, intel-wired-lan@...ts.osuosl.org, jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com, keescook@...omium.org, grzegorzx.szczurek@...el.com, mateusz.palczewski@...el.com, mitch.a.williams@...el.com, gregory.v.rose@...el.com, jeffrey.t.kirsher@...el.com, michal.kubiak@...el.com, simon.horman@...igine.com, madhu.chittim@...el.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, pengdonglin@...gfor.com.cn, huangcun@...gfor.com.cn Subject: Re: [PATCH net v4 2/2] iavf: Fix out-of-bounds when setting channels on remove On Wed, 3 May 2023 11:24:58 +0300 Leon Romanovsky wrote: > > + if (test_bit(__IAVF_IN_REMOVE_TASK, &adapter->crit_section)) > > + return -EOPNOTSUPP; > > This makes no sense without locking as change to __IAVF_IN_REMOVE_TASK > can happen any time. +1, the changes look questionable to me as well.
Powered by blists - more mailing lists