netdev - Re: [PATCH] vhost_net: Use fdget() and fdput()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 May 2023 14:45:28 +0800
From: Jason Wang <jasowang@...hat.com>
To: ye.xingchen@....com.cn
Cc: mst@...hat.com, kvm@...r.kernel.org, 
	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vhost_net: Use fdget() and fdput()

On Fri, May 5, 2023 at 2:24 PM <ye.xingchen@....com.cn> wrote:
>
> From: Ye Xingchen <ye.xingchen@....com.cn>
>
> convert the fget()/fput() uses to fdget()/fdput().

What's the advantages of this?

Thanks

>
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>
> ---
>  drivers/vhost/net.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index ae2273196b0c..5b3fe4805182 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -1466,17 +1466,17 @@ static struct ptr_ring *get_tap_ptr_ring(struct file *file)
>
>  static struct socket *get_tap_socket(int fd)
>  {
> -       struct file *file = fget(fd);
> +       struct fd f = fdget(fd);
>         struct socket *sock;
>
> -       if (!file)
> +       if (!f.file)
>                 return ERR_PTR(-EBADF);
> -       sock = tun_get_socket(file);
> +       sock = tun_get_socket(f.file);
>         if (!IS_ERR(sock))
>                 return sock;
> -       sock = tap_get_socket(file);
> +       sock = tap_get_socket(f.file);
>         if (IS_ERR(sock))
> -               fput(file);
> +               fdput(f);
>         return sock;
>  }
>
> --
> 2.25.1
>