lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAM0EoM=upsZ1QFokoR5=A4E8Sp=U+UbXDq-jO5r_7pOcq4OL0w@mail.gmail.com> Date: Mon, 8 May 2023 07:23:23 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: Peilin Ye <yepeilin.cs@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Peilin Ye <peilin.ye@...edance.com>, Daniel Borkmann <daniel@...earbox.net>, John Fastabend <john.r.fastabend@...el.com>, Vlad Buslov <vladbu@...lanox.com>, Pedro Tammela <pctammela@...atatu.com>, Hillf Danton <hdanton@...a.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Cong Wang <cong.wang@...edance.com> Subject: Re: [PATCH net 2/6] net/sched: sch_clsact: Only create under TC_H_CLSACT On Fri, May 5, 2023 at 8:13 PM Peilin Ye <yepeilin.cs@...il.com> wrote: > > clsact Qdiscs are only supposed to be created under TC_H_CLSACT (which > equals TC_H_INGRESS). Return -EOPNOTSUPP if 'parent' is not > TC_H_CLSACT. > > Fixes: 1f211a1b929c ("net, sched: add clsact qdisc") > Signed-off-by: Peilin Ye <peilin.ye@...edance.com> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com> Acked-by: Jamal Hadi Salim <jhs@...atatu.com> cheers, jamal > --- > net/sched/sch_ingress.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c > index 3d71f7a3b4ad..13218a1fe4a5 100644 > --- a/net/sched/sch_ingress.c > +++ b/net/sched/sch_ingress.c > @@ -222,6 +222,9 @@ static int clsact_init(struct Qdisc *sch, struct nlattr *opt, > struct net_device *dev = qdisc_dev(sch); > int err; > > + if (sch->parent != TC_H_CLSACT) > + return -EOPNOTSUPP; > + > net_inc_ingress_queue(); > net_inc_egress_queue(); > > -- > 2.20.1 >
Powered by blists - more mailing lists