lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAM0EoMng6Au3SfHkBuaXu1c1o6U3+iSR_csH7DsZRpGBvZn_TQ@mail.gmail.com> Date: Mon, 8 May 2023 07:22:54 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: Peilin Ye <yepeilin.cs@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Peilin Ye <peilin.ye@...edance.com>, Daniel Borkmann <daniel@...earbox.net>, John Fastabend <john.r.fastabend@...el.com>, Vlad Buslov <vladbu@...lanox.com>, Pedro Tammela <pctammela@...atatu.com>, Hillf Danton <hdanton@...a.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Cong Wang <cong.wang@...edance.com> Subject: Re: [PATCH net 1/6] net/sched: sch_ingress: Only create under TC_H_INGRESS On Fri, May 5, 2023 at 8:12 PM Peilin Ye <yepeilin.cs@...il.com> wrote: > > ingress Qdiscs are only supposed to be created under TC_H_INGRESS. > Similar to mq_init(), return -EOPNOTSUPP if 'parent' is not > TC_H_INGRESS. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Reported-by: syzbot+b53a9c0d1ea4ad62da8b@...kaller.appspotmail.com > Link: https://lore.kernel.org/netdev/0000000000006cf87705f79acf1a@google.com > Signed-off-by: Peilin Ye <peilin.ye@...edance.com> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com> Acked-by: Jamal Hadi Salim <jhs@...atatu.com> cheers, jamal > --- > net/sched/sch_ingress.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c > index 84838128b9c5..3d71f7a3b4ad 100644 > --- a/net/sched/sch_ingress.c > +++ b/net/sched/sch_ingress.c > @@ -80,6 +80,9 @@ static int ingress_init(struct Qdisc *sch, struct nlattr *opt, > struct net_device *dev = qdisc_dev(sch); > int err; > > + if (sch->parent != TC_H_INGRESS) > + return -EOPNOTSUPP; > + > net_inc_ingress_queue(); > > mini_qdisc_pair_init(&q->miniqp, sch, &dev->miniq_ingress); > -- > 2.20.1 >
Powered by blists - more mailing lists