netdev - Re: [PATCH bpf v7 12/13] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fs873wa7.fsf@cloudflare.com>
Date: Mon, 08 May 2023 13:19:32 +0200
From: Jakub Sitnicki <jakub@...udflare.com>
To: John Fastabend <john.fastabend@...il.com>
Cc: daniel@...earbox.net, lmb@...valent.com, edumazet@...gle.com,
 bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...nel.org,
 andrii@...nel.org, will@...valent.com
Subject: Re: [PATCH bpf v7 12/13] bpf: sockmap, test FIONREAD returns
 correct bytes in rx buffer

On Tue, May 02, 2023 at 08:51 AM -07, John Fastabend wrote:
> A bug was reported where ioctl(FIONREAD) returned zero even though the
> socket with a SK_SKB verdict program attached had bytes in the msg
> queue. The result is programs may hang or more likely try to recover,
> but use suboptimal buffer sizes.
>
> Add a test to check that ioctl(FIONREAD) returns the correct number of
> bytes.
>
> Signed-off-by: John Fastabend <john.fastabend@...il.com>
> ---

Reviewed-by: Jakub Sitnicki <jakub@...udflare.com>