netdev - Re: [PATCH bpf v7 13/13] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer with drops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bkiv3vkv.fsf@cloudflare.com>
Date: Mon, 08 May 2023 13:34:27 +0200
From: Jakub Sitnicki <jakub@...udflare.com>
To: John Fastabend <john.fastabend@...il.com>
Cc: daniel@...earbox.net, lmb@...valent.com, edumazet@...gle.com,
 bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...nel.org,
 andrii@...nel.org, will@...valent.com
Subject: Re: [PATCH bpf v7 13/13] bpf: sockmap, test FIONREAD returns
 correct bytes in rx buffer with drops

On Tue, May 02, 2023 at 08:51 AM -07, John Fastabend wrote:
> When BPF program drops pkts the sockmap logic 'eats' the packet and
> updates copied_seq. In the PASS case where the sk_buff is accepted
> we update copied_seq from recvmsg path so we need a new test to
> handle the drop case.
>
> Original patch series broke this resulting in
>
> test_sockmap_skb_verdict_fionread:PASS:ioctl(FIONREAD) error 0 nsec
> test_sockmap_skb_verdict_fionread:FAIL:ioctl(FIONREAD) unexpected ioctl(FIONREAD): actual 1503041772 != expected 256
> #176/17  sockmap_basic/sockmap skb_verdict fionread on drop:FAIL
>
> After updated patch with fix.
>
> #176/16  sockmap_basic/sockmap skb_verdict fionread:OK
> #176/17  sockmap_basic/sockmap skb_verdict fionread on drop:OK
>
> Signed-off-by: John Fastabend <john.fastabend@...il.com>
> ---

Reviewed-by: Jakub Sitnicki <jakub@...udflare.com>