lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZFjdpncRYi2N0gGQ@pengutronix.de> Date: Mon, 8 May 2023 13:31:50 +0200 From: Sascha Hauer <s.hauer@...gutronix.de> To: Christian Marangi <ansuelsmth@...il.com> Cc: Jonathan Corbet <corbet@....net>, Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 07/11] leds: trigger: netdev: reject interval and device store for hw_control Hi Christian, On Thu, Apr 27, 2023 at 02:15:37AM +0200, Christian Marangi wrote: > Reject interval and device store with hw_control enabled. They are > currently not supported and MUST be empty with hw_control enabled. > > Signed-off-by: Christian Marangi <ansuelsmth@...il.com> > --- > drivers/leds/trigger/ledtrig-netdev.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c > index 28c4465a2584..8cd876647a27 100644 > --- a/drivers/leds/trigger/ledtrig-netdev.c > +++ b/drivers/leds/trigger/ledtrig-netdev.c > @@ -248,6 +255,13 @@ static ssize_t interval_store(struct device *dev, > unsigned long value; > int ret; > > + mutex_lock(&trigger_data->lock); > + > + if (trigger_data->hw_control) { > + size = -EINVAL; > + goto out; > + } > + > ret = kstrtoul(buf, 0, &value); > if (ret) > return ret; You return with the mutex held here. You could do the kstrtoul() before acquiring the mutex. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists