netdev - RE: [EXT] Re: [RESEND PATCH v4 net 1/1] net: fec: correct the counting of XDP sent frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 9 May 2023 02:19:10 +0000
From: Shenwei Wang <shenwei.wang@....com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Wei Fang <wei.fang@....com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Clark Wang
	<xiaoning.wang@....com>, dl-linux-imx <linux-imx@....com>, Alexei Starovoitov
	<ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard
 Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>,
	Alexander Lobakin <alexandr.lobakin@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	Gagandeep Singh <G.Singh@....com>
Subject: RE: [EXT] Re: [RESEND PATCH v4 net 1/1] net: fec: correct the
 counting of XDP sent frames



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Monday, May 8, 2023 8:46 PM
> To: Shenwei Wang <shenwei.wang@....com>
> Cc: Wei Fang <wei.fang@....com>; David S. Miller <davem@...emloft.net>;
> Eric Dumazet <edumazet@...gle.com>; Paolo Abeni <pabeni@...hat.com>;
> Clark Wang <xiaoning.wang@....com>; dl-linux-imx <linux-imx@....com>;
> Alexei Starovoitov <ast@...nel.org>; Daniel Borkmann <daniel@...earbox.net>;
> Jesper Dangaard Brouer <hawk@...nel.org>; John Fastabend
> <john.fastabend@...il.com>; Alexander Lobakin
> <alexandr.lobakin@...el.com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; imx@...ts.linux.dev; Gagandeep Singh
> <G.Singh@....com>
> Subject: [EXT] Re: [RESEND PATCH v4 net 1/1] net: fec: correct the counting of
> XDP sent frames
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
>
>
> On Mon,  8 May 2023 09:38:31 -0500 Shenwei Wang wrote:
> > In the current xdp_xmit implementation, if any single frame fails to
> > transmit due to insufficient buffer descriptors, the function
> > nevertheless reports success in sending all frames. This results in
> > erroneously indicating that frames were transmitted when in fact they were
> dropped.
> >
> > This patch fixes the issue by ensureing the return value properly
> > indicates the actual number of frames successfully transmitted, rather
> > than potentially reporting success for all frames when some could not transmit.
> >
> > Fixes: 6d6b39f180b8 ("net: fec: add initial XDP support")
> > Signed-off-by: Gagandeep Singh <g.singh@....com>
> > Signed-off-by: Shenwei Wang <shenwei.wang@....com>
>
> Unfortunately the previous version was silently applied, it seems:
>
> https://git.kernel/
> .org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnetdev%2Fnet.git%2Fcommit
> %2F%3Fid%3D26312c685ae0bca61e06ac75ee158b1e69546415&data=05%7C01
> %7Cshenwei.wang%40nxp.com%7C50d9af4da79646cf2d2b08db502f2b7d%7C6
> 86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638191935747226987%7C
> Unknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6I
> k1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=O2uy5iy4QJa9v8TN9t
> qM7jqIgVhBY7pMxl4K58abj9s%3D&reserved=0
>
> Could you send an incremental fix, on top of that patch?

Certainly, I will.

Thanks,
Shenwei

> --
> pw-bot: cr