lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230508184608.43376a10@kernel.org>
Date: Mon, 8 May 2023 18:46:08 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shenwei Wang <shenwei.wang@....com>
Cc: Wei Fang <wei.fang@....com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Clark
 Wang <xiaoning.wang@....com>, NXP Linux Team <linux-imx@....com>, Alexei
 Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend
 <john.fastabend@...il.com>, Alexander Lobakin <alexandr.lobakin@...el.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 Gagandeep Singh <g.singh@....com>
Subject: Re: [RESEND PATCH v4 net 1/1] net: fec: correct the counting of XDP
 sent frames

On Mon,  8 May 2023 09:38:31 -0500 Shenwei Wang wrote:
> In the current xdp_xmit implementation, if any single frame fails to
> transmit due to insufficient buffer descriptors, the function nevertheless
> reports success in sending all frames. This results in erroneously
> indicating that frames were transmitted when in fact they were dropped.
> 
> This patch fixes the issue by ensureing the return value properly
> indicates the actual number of frames successfully transmitted, rather than
> potentially reporting success for all frames when some could not transmit.
> 
> Fixes: 6d6b39f180b8 ("net: fec: add initial XDP support")
> Signed-off-by: Gagandeep Singh <g.singh@....com>
> Signed-off-by: Shenwei Wang <shenwei.wang@....com>

Unfortunately the previous version was silently applied, it seems:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=26312c685ae0bca61e06ac75ee158b1e69546415

Could you send an incremental fix, on top of that patch?
-- 
pw-bot: cr

Powered by blists - more mailing lists