netdev - RE: [PATCH net-next v2 04/11] net: stmmac: dwmac-visconti: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYWPR01MB94204DF359A14DDEB5C7748092769@TYWPR01MB9420.jpnprd01.prod.outlook.com>
Date: Tue, 9 May 2023 02:28:11 +0000
From: <nobuhiro1.iwamatsu@...hiba.co.jp>
To: <u.kleine-koenig@...gutronix.de>, <peppe.cavallaro@...com>,
        <alexandre.torgue@...s.st.com>, <joabreu@...opsys.com>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <mcoquelin.stm32@...il.com>
CC: <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>, <kernel@...gutronix.de>,
        <simon.horman@...igine.com>
Subject: RE: [PATCH net-next v2 04/11] net: stmmac: dwmac-visconti: Convert to
 platform remove callback returning void

Hi Uwe,

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Sent: Monday, May 8, 2023 11:27 PM
> To: Giuseppe Cavallaro <peppe.cavallaro@...com>; Alexandre Torgue
> <alexandre.torgue@...s.st.com>; Jose Abreu <joabreu@...opsys.com>;
> David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○
> ＯＳＴ) <nobuhiro1.iwamatsu@...hiba.co.jp>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>
> Cc: netdev@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-stm32@...md-mailman.stormreply.com; kernel@...gutronix.de; Simon
> Horman <simon.horman@...igine.com>
> Subject: [PATCH net-next v2 04/11] net: stmmac: dwmac-visconti: Convert to
> platform remove callback returning void
> 
> The .remove() callback for a platform driver returns an int which makes many
> driver authors wrongly assume it's possible to do error handling by returning an
> error code. However the value returned is (mostly) ignored and this typically
> results in resource leaks. To improve here there is a quest to make the remove
> callback return void. In the first step of this quest all drivers are converted
> to .remove_new() which already returns void.
> 
> Trivially convert this driver from always returning zero in the remove callback to
> the void returning variant.
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>

Best regards,
  Nobuhiro