lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <007ca679-2ba7-635f-942f-deee52e70117@ti.com> Date: Tue, 9 May 2023 10:12:16 +0530 From: Siddharth Vadapalli <s-vadapalli@...com> To: Jakub Kicinski <kuba@...nel.org> CC: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>, <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <srk@...com>, <s-vadapalli@...com> Subject: Re: [PATCH net] net: phy: dp83867: add w/a for packet errors seen with short cables On 09/05/23 07:30, Jakub Kicinski wrote: > Thanks for the patch! Some nit picks below.. > > On Mon, 8 May 2023 12:30:19 +0530 Siddharth Vadapalli wrote: >> + err = phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_DSP_FFE_CFG, 0X0E81); > > Pleas wrap this line at 80 characters, there's no reason for it > to be this long. > > And 0x prefix should not be in upper case, here and in the new define > you're adding. Thank you for pointing out the issues. I will fix them and post the v2 patch. -- Regards, Siddharth.
Powered by blists - more mailing lists