netdev - Re: mv88e6320: Failed to forward PTP multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 May 2023 08:03:01 -0300
From: Fabio Estevam <festevam@...il.com>
To: Vladimir Oltean <olteanv@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, tobias@...dekranz.com, 
	Florian Fainelli <f.fainelli@...il.com>, Steffen Bätz <steffen@...osonix.de>, 
	netdev <netdev@...r.kernel.org>
Subject: Re: mv88e6320: Failed to forward PTP multicast

Hi Vladimir,

On Wed, May 10, 2023 at 3:28 PM Vladimir Oltean <olteanv@...il.com> wrote:

> I checked out the v6.1.26 tag from linux-stable and I was able to
> synchronize 2 stations attached to my Turris MOX (Marvell 6190) with
> this commands: sudo ptp4l -i eth0 -4 -m
> (also I was able to synchronize a third station behind a mvneta bridge
> port foreign to the MV88E6190, using software forwarding)

Thanks for testing it, appreciate it.

> My bridge configuration is VLAN-aware. FWIW, I'm using vlan_default_pvid
> 1000, but it should not make a difference.
>
> In a bridging configuration where there are only 2 ports in the bridge
> PVID (1 source and 1 destination), could you please run the following
> command from a station attached to one of the Marvell switch ports:
>
> board # ethtool -S lanX | grep -v ': 0'
> station # mausezahn eth0 -B 224.0.1.129 -c 1000 -t udp "dp=319"
> board # ethtool -S lanX | grep -v ': 0'
>
> and tell me which counters increment?

In our tests:
eth0 is the port connected to the i.MX8MN.
eth1 and eth2 are the Marvell switch ports

Please find attached two configurations and the results.

Some notes:

- We have bridged (eth1+eth2) = br0, no matter if it is VLAN aware or not.
- PTP traffic flows correctly over eth1+eth2 (the 2 hardware switch interfaces)
- PTP traffic appears shortly, (like during 30 seconds) on the
non-VLAN-aware case
br0 interface.
- PTP traffic does not appear on the VLAN-aware br0 interface

> I am also curious whether there is any difference to your setup between:
> ip link add br0 type bridge
> ip link set br0 type bridge vlan_filtering 1 # dynamic toggling of VLAN awareness
> and:
> ip link add br0 type bridge vlan_filtering 1 # static creation of VLAN-aware bridge

It does not show any difference here.

> I've tested both forms on my setup, and both work. Who knows, maybe
> something happens differently on your particular kernel, or with your
> particular switch model.
>
> Is it vanilla v6.1.26 or something else?

It is vanilla v6.1.26 plus the devicetree for this board, plus an
audio codec patch.

Thanks,

Fabio Estevam

Download attachment "mausezahn.tar.xz" of type "application/x-xz" (1248 bytes)