netdev - Re: [PATCH net-next v4 1/7] net: wangxun: libwx add tx offload functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZF5KPjbVHtSpvH2x@corigine.com>
Date: Fri, 12 May 2023 16:16:30 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Mengyuan Lou <mengyuanlou@...-swift.com>
Cc: netdev@...r.kernel.org, jiawenwu@...stnetic.com
Subject: Re: [PATCH net-next v4 1/7] net: wangxun: libwx add tx offload
 functions

On Wed, May 10, 2023 at 05:38:39PM +0800, Mengyuan Lou wrote:
> Add tx offload functions for wx_xmit_frame_ring which
> includes wx_encode_tx_desc_ptype, wx_tso and wx_tx_csum.
> which supports ngbe and txgbe to implement tx offload
> function.
> 
> Signed-off-by: Mengyuan Lou <mengyuanlou@...-swift.com>

...

> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_type.h b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> index 32f952d93009..70f5fd168e40 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_type.h
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> @@ -6,6 +6,7 @@
>  
>  #include <linux/bitfield.h>
>  #include <linux/netdevice.h>
> +#include <net/ip.h>
>  
>  #define WX_NCSI_SUP                             0x8000
>  #define WX_NCSI_MASK                            0x8000
> @@ -315,9 +316,6 @@
>  #define TXD_USE_COUNT(S)     DIV_ROUND_UP((S), WX_MAX_DATA_PER_TXD)
>  #define DESC_NEEDED          (MAX_SKB_FRAGS + 4)
>  
> -/* Ether Types */
> -#define WX_ETH_P_CNM                 0x22E7
> -
>  #define WX_CFG_PORT_ST               0x14404
>  
>  /******************* Receive Descriptor bit definitions **********************/

nit: this comment is not in Kernel doc format, so it should not start with /**