netdev - Re: [PATCH net-next v4 2/7] net: wangxun: libwx add rx offload functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9715EEB3-0BAD-4D01-A0FA-101B3346F34C@net-swift.com>
Date: Mon, 15 May 2023 09:31:36 +0800
From: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
To: Yunsheng Lin <linyunsheng@...wei.com>
Cc: netdev@...r.kernel.org,
 Jiawen Wu <jiawenwu@...stnetic.com>
Subject: Re: [PATCH net-next v4 2/7] net: wangxun: libwx add rx offload
 functions



> 2023年5月12日 19:41，Yunsheng Lin <linyunsheng@...wei.com> 写道：
> 
> On 2023/5/12 14:00, mengyuanlou@...-swift.com wrote:
>>> 2023年5月11日 19:48，Yunsheng Lin <linyunsheng@...wei.com> 写道：
>>> 
>>> On 2023/5/11 16:34, mengyuanlou@...-swift.com wrote:
>>>>>> @@ -321,8 +321,31 @@
>>>>> 
>>>>> ...
>>>>> 
>>>>>> +
>>>>>> +static inline struct wx_dec_ptype wx_decode_ptype(const u8 ptype)
>>>>> 
>>>>> If the above is only used in one .c file, maybe it does not need
>>>>> to be in the .h file?
>>>> 
>>>> If I put it to .c file which use it, when compiling the other .c files will say
>>>> "warning: ‘wx_ptype_lookup’ defined but not used”.
>>> 
>>> Is 'wx_ptype_lookup' used in other .c file? if not, why not move
>>> it to .c file too?
>>> 
>> I mean how to you fix this compile warning.
> 
> Doesn't moving wx_decode_ptype() and wx_ptype_lookup to the
> same C file solve the problem?
> 
Yeah，
Put it in .h do not has the problem.
Put it in C file, it comes. 
>> 
>>>>> 
>>>>>> +{
>>>>>> + return wx_ptype_lookup[ptype];
>>>>>> +}
>>>>>> +
>>> 
>> 
>> 
>> .
>> 
>