netdev - Re: [PATCH net] erspan: get the proto with the md version for collect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZF5u3INWj6gQswjX@corigine.com>
Date: Fri, 12 May 2023 18:52:44 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Xin Long <lucien.xin@...il.com>
Cc: network dev <netdev@...r.kernel.org>, davem@...emloft.net,
	kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>, William Tu <u9012063@...il.com>,
	Kevin Traynor <ktraynor@...hat.com>
Subject: Re: [PATCH net] erspan: get the proto with the md version for
 collect_md

On Thu, May 11, 2023 at 07:22:11PM -0400, Xin Long wrote:
> In commit 20704bd1633d ("erspan: build the header with the right proto
> according to erspan_ver"), it gets the proto with t->parms.erspan_ver,
> but t->parms.erspan_ver is not used by collect_md branch, and instead
> it should get the proto with md->version for collect_md.
> 
> Thanks to Kevin for pointing this out.
> 
> Fixes: 94d7d8f29287 ("ip6_gre: add erspan v2 support")

Hi Xin,

In a way this fixes the following commit which in turn fixes the above
commit.

Fixes: 20704bd1633d ("erspan: build the header with the right proto according to erspan_ver")

> Reported-by: Kevin Traynor <ktraynor@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>