netdev - Re: [PATCH net] erspan: get the proto with the md version for collect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALDO+Saq9yJ34KRK5n-e=TvKYLO9PXG=0h9jOh2J0GMkpPQyLA@mail.gmail.com>
Date: Fri, 12 May 2023 11:55:01 -0700
From: William Tu <u9012063@...il.com>
To: Xin Long <lucien.xin@...il.com>
Cc: network dev <netdev@...r.kernel.org>, davem@...emloft.net, kuba@...nel.org, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	Kevin Traynor <ktraynor@...hat.com>
Subject: Re: [PATCH net] erspan: get the proto with the md version for collect_md

On Thu, May 11, 2023 at 4:22 PM Xin Long <lucien.xin@...il.com> wrote:
>
> In commit 20704bd1633d ("erspan: build the header with the right proto
> according to erspan_ver"), it gets the proto with t->parms.erspan_ver,
> but t->parms.erspan_ver is not used by collect_md branch, and instead
> it should get the proto with md->version for collect_md.
>
> Thanks to Kevin for pointing this out.
>
> Fixes: 94d7d8f29287 ("ip6_gre: add erspan v2 support")
> Reported-by: Kevin Traynor <ktraynor@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---

Hi Xin,
LGTM, thanks for fixing this.
Reviewed-by: William Tu <u9012063@...il.com>