netdev - Re: [PATCH RFC net-next 3/9] net: phylink: add function to resolve clause 73 negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6b07fbe-3566-42a2-9c7c-057b6cf63f09@lunn.ch>
Date: Sat, 13 May 2023 15:55:51 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Jose Abreu <Jose.Abreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH RFC net-next 3/9] net: phylink: add function to resolve
 clause 73 negotiation

> > Hi Russell
> > 
> > This looks asymmetric in that state->link is not set true if a
> > resolution is found.
> > 
> > Can that set be moved here? Or are there other conditions which also
> > need to be fulfilled before it is set?
> 
> It's intentionally so because it's a failure case. In theory, the
> PHY shouldn't report link-up if the C73 priority resolution doesn't
> give a valid result, but given that there are C73 advertisements
> that we don't support, and that the future may add further
> advertisements, if our software resolution fails to find a speed,
> we need to stop the link coming up. Also... PHYs... hardware
> bugs...

Thanks for the explanation.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew