netdev - Re: [PATCH RFC net-next 6/9] net: pcs: xpcs: correct lp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0b2ace1-39ae-4a72-94d2-e70e44b45ad6@lunn.ch>
Date: Sat, 13 May 2023 19:39:42 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Jose Abreu <Jose.Abreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH RFC net-next 6/9] net: pcs: xpcs: correct lp_advertising
 contents

On Fri, May 12, 2023 at 06:27:30PM +0100, Russell King (Oracle) wrote:
> lp_advertising is supposed to reflect the link partner's advertisement
> unmodified by the local advertisement, but xpcs bitwise ands it with
> the local advertisement prior to calculating the resolution of the
> negotiation.
> 
> Fix this by moving the bitwise and to xpcs_resolve_lpa_c73() so it can
> place the results in a temporary bitmap before passing that to
> ixpcs_get_max_usxgmii_speed().
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew