| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 May 2023 17:14:00 +0800
From: kernel test robot <lkp@...el.com>
To: Rudi Heitbaum <rudi@...tbaum.com>, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, wens@...e.org, jernej.skrabec@...il.com,
samuel@...lland.org, marcel@...tmann.org, johan.hedberg@...il.com,
luiz.dentz@...il.com, anarsoul@...il.com, alistair@...stair23.me
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-bluetooth@...r.kernel.org,
Rudi Heitbaum <rudi@...tbaum.com>
Subject: Re: [PATCH 2/3] Bluetooth: btrtl: Add support for RTL8822BS UART
Hi Rudi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bb7c241fae6228e89c0286ffd6f249b3b0dea225]
url: https://github.com/intel-lab-lkp/linux/commits/Rudi-Heitbaum/dt-bindings-net-realtek-bluetooth-Add-RTL8822BS/20230514-155000
base: bb7c241fae6228e89c0286ffd6f249b3b0dea225
patch link: https://lore.kernel.org/r/20230514074731.70614-3-rudi%40heitbaum.com
patch subject: [PATCH 2/3] Bluetooth: btrtl: Add support for RTL8822BS UART
config: arm-randconfig-r004-20230514
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project b0fb98227c90adf2536c9ad644a74d5e92961111)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/intel-lab-lkp/linux/commit/2f68c37a4fd8f66ba45a8ff74d845954644401e0
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Rudi-Heitbaum/dt-bindings-net-realtek-bluetooth-Add-RTL8822BS/20230514-155000
git checkout 2f68c37a4fd8f66ba45a8ff74d845954644401e0
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/bluetooth/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305141652.RsLrMY8N-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/bluetooth/btrtl.c:1195:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
drivers/bluetooth/btrtl.c:1195:2: note: insert '__attribute__((fallthrough));' to silence this warning
default:
^
__attribute__((fallthrough));
drivers/bluetooth/btrtl.c:1195:2: note: insert 'break;' to avoid fall-through
default:
^
break;
1 warning generated.
vim +1195 drivers/bluetooth/btrtl.c
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1164
3011faa29bc6f45 Archie Pusaka 2021-05-27 1165 void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1166 {
65251e2e0ad379d Alex Lu 2019-08-30 1167 /* Enable controller to do both LE scan and BR/EDR inquiry
65251e2e0ad379d Alex Lu 2019-08-30 1168 * simultaneously.
65251e2e0ad379d Alex Lu 2019-08-30 1169 */
65251e2e0ad379d Alex Lu 2019-08-30 1170 set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
65251e2e0ad379d Alex Lu 2019-08-30 1171
05672a2c14a4ea2 Abhishek Pandit-Subedi 2020-12-22 1172 /* Enable central-peripheral role (able to create new connections with
05672a2c14a4ea2 Abhishek Pandit-Subedi 2020-12-22 1173 * an existing connection in slave role).
05672a2c14a4ea2 Abhishek Pandit-Subedi 2020-12-22 1174 */
9ab9235fe5cf7f8 Max Chou 2021-01-27 1175 /* Enable WBS supported for the specific Realtek devices. */
9ab9235fe5cf7f8 Max Chou 2021-01-27 1176 switch (btrtl_dev->project_id) {
9ab9235fe5cf7f8 Max Chou 2021-01-27 1177 case CHIP_ID_8822C:
9ab9235fe5cf7f8 Max Chou 2021-01-27 1178 case CHIP_ID_8852A:
18e8055c88142d8 Max Chou 2022-03-14 1179 case CHIP_ID_8852B:
8b1d66b50437b65 Max Chou 2022-04-11 1180 case CHIP_ID_8852C:
7948fe1c92d9231 Max Chou 2023-04-18 1181 case CHIP_ID_8851B:
05672a2c14a4ea2 Abhishek Pandit-Subedi 2020-12-22 1182 set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
9ab9235fe5cf7f8 Max Chou 2021-01-27 1183 set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
a479e71322ced3e Hilda Wu 2022-10-05 1184
a479e71322ced3e Hilda Wu 2022-10-05 1185 /* RTL8852C needs to transmit mSBC data continuously without
a479e71322ced3e Hilda Wu 2022-10-05 1186 * the zero length of USB packets for the ALT 6 supported chips
a479e71322ced3e Hilda Wu 2022-10-05 1187 */
a479e71322ced3e Hilda Wu 2022-10-05 1188 if (btrtl_dev->project_id == CHIP_ID_8852C)
a479e71322ced3e Hilda Wu 2022-10-05 1189 btrealtek_set_flag(hdev, REALTEK_ALT6_CONTINUOUS_TX_CHIP);
a479e71322ced3e Hilda Wu 2022-10-05 1190
099c6d31764b97d Joseph Hwang 2021-09-26 1191 hci_set_aosp_capable(hdev);
05672a2c14a4ea2 Abhishek Pandit-Subedi 2020-12-22 1192 break;
2f68c37a4fd8f66 Rudi Heitbaum 2023-05-14 1193 case CHIP_ID_8822B:
2f68c37a4fd8f66 Rudi Heitbaum 2023-05-14 1194 set_bit(HCI_QUIRK_BROKEN_LOCAL_EXT_FEATURES_PAGE_2, &hdev->quirks);
05672a2c14a4ea2 Abhishek Pandit-Subedi 2020-12-22 @1195 default:
05672a2c14a4ea2 Abhishek Pandit-Subedi 2020-12-22 1196 rtl_dev_dbg(hdev, "Central-peripheral role not enabled.");
9ab9235fe5cf7f8 Max Chou 2021-01-27 1197 rtl_dev_dbg(hdev, "WBS supported not enabled.");
05672a2c14a4ea2 Abhishek Pandit-Subedi 2020-12-22 1198 break;
05672a2c14a4ea2 Abhishek Pandit-Subedi 2020-12-22 1199 }
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1200
253cf30e8d3d001 Max Chou 2023-03-21 1201 if (!btrtl_dev->ic_info)
253cf30e8d3d001 Max Chou 2023-03-21 1202 return;
253cf30e8d3d001 Max Chou 2023-03-21 1203
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1204 switch (btrtl_dev->ic_info->lmp_subver) {
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1205 case RTL_ROM_LMP_8703B:
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1206 /* 8723CS reports two pages for local ext features,
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1207 * but it doesn't support any features from page 2 -
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1208 * it either responds with garbage or with error status
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1209 */
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1210 set_bit(HCI_QUIRK_BROKEN_LOCAL_EXT_FEATURES_PAGE_2,
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1211 &hdev->quirks);
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1212 break;
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1213 default:
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1214 break;
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1215 }
3011faa29bc6f45 Archie Pusaka 2021-05-27 1216 }
3011faa29bc6f45 Archie Pusaka 2021-05-27 1217 EXPORT_SYMBOL_GPL(btrtl_set_quirks);
3011faa29bc6f45 Archie Pusaka 2021-05-27 1218
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
View attachment "config" of type "text/plain" (148397 bytes)
Powered by blists - more mailing lists