lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4c163376-ce89-786d-3c76-4f10ae818e7a@linaro.org> Date: Sun, 14 May 2023 11:15:40 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Simon Horman <simon.horman@...igine.com> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Samuel Ortiz <sameo@...ux.intel.com>, Thierry Escande <thierry.escande@...labora.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] nfx: llcp: fix possible use of uninitialized variable in nfc_llcp_send_connect() On 14/05/2023 10:29, Simon Horman wrote: > On Sat, May 13, 2023 at 01:51:12PM +0200, Krzysztof Kozlowski wrote: >> On 13/05/2023 13:49, Krzysztof Kozlowski wrote: >>> If sock->service_name is NULL, the local variable >>> service_name_tlv_length will not be assigned by nfc_llcp_build_tlv(), >>> later leading to using value frmo the stack. Smatch warning: >>> >>> net/nfc/llcp_commands.c:442 nfc_llcp_send_connect() error: uninitialized symbol 'service_name_tlv_length'. >> >> Eh, typo in subject prefix. V2 in shortly... > > Also, s/frmo/from/ > > And please consider moving local variables towards reverse xmas tree - > longest line to shortest - order for networking code. They were not ordered in the first place, so you prefer me to re-shuffle all of them (a bit independent change)? Best regards, Krzysztof
Powered by blists - more mailing lists