netdev - [PATCH iwl-net v1 0/2] Fix for bond 802.3ad mode with VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 May 2023 09:44:45 -0400
From: Mateusz Palczewski <mateusz.palczewski@...el.com>
To: j.vosburgh@...il.com,
	andy@...yhouse.net,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	dbanerje@...mai.com,
	netdev@...r.kernel.org
Cc: Mateusz Palczewski <mateusz.palczewski@...el.com>
Subject: [PATCH iwl-net  v1 0/2] Fix for bond 802.3ad mode with VFs

Bond 802.3ad mode with PFs works fine.

Problem appears when one or both of the nodes contains VFs.
Let's assume there is setup with 2 hosts, on both there are 2 PFs with each one with 1 VFs.
Bond(802.3ad)--|--VFs(two VFs)--Switch(with lacp enabled)--VFs-Bond(802.3ad)
In this particular scenario, there are 2 problems:

1. VFs needs some more time than PFs to set the link up, bonding drivers checks link only once, without any delay.
This caused issues with setting up bonding link. Fixed by adding small delay loop which checks link state.
2. Only master link works properly. Slave link cannot negotiate connection. This happens because permanent hw address
is used for creating lacpdu packets, not current address. Fixed by using current hw address to create lacpdu packet.

Sebastian Basierski (2):
  drivers/net/bonding/bond_3ad: Use updated MAC address for lacpdu
    packets
  drivers/net/bonding: Added some delay while checking for VFs link

 drivers/net/bonding/bond_3ad.c  |  4 ++--
 drivers/net/bonding/bond_main.c | 14 +++++++++++++-
 2 files changed, 15 insertions(+), 3 deletions(-)

-- 
2.31.1