netdev - [PATCH iwl-net v1 1/2] drivers/net/bonding/bond_3ad: Use updated MAC address for lacpdu packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230516134447.193511-2-mateusz.palczewski@intel.com>
Date: Tue, 16 May 2023 09:44:46 -0400
From: Mateusz Palczewski <mateusz.palczewski@...el.com>
To: j.vosburgh@...il.com,
	andy@...yhouse.net,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	dbanerje@...mai.com,
	netdev@...r.kernel.org
Cc: Sebastian Basierski <sebastianx.basierski@...el.com>,
	Mateusz Palczewski <mateusz.palczewski@...el.com>
Subject: [PATCH iwl-net  v1 1/2] drivers/net/bonding/bond_3ad: Use updated MAC address for lacpdu packets

From: Sebastian Basierski <sebastianx.basierski@...el.com>

After changing VFs MAC address, bonding driver shouldn't use
the old address. Otherwise lapcdu packets will have set wrong
source MAC address.

Fixes: ada0f8633c5b ("bonding: Convert memcpy(foo, bar, ETH_ALEN) to ether_addr_copy(foo, bar)")
Signed-off-by: Sebastian Basierski <sebastianx.basierski@...el.com>
Signed-off-by: Mateusz Palczewski <mateusz.palczewski@...el.com>
---
 drivers/net/bonding/bond_3ad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index c99ffe6c683a..b5202af79f20 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -869,10 +869,10 @@ static int ad_lacpdu_send(struct port *port)
 	lacpdu_header = skb_put(skb, length);
 
 	ether_addr_copy(lacpdu_header->hdr.h_dest, lacpdu_mcast_addr);
-	/* Note: source address is set to be the member's PERMANENT address,
+	/* Note: source address is set to be the member's CURRENT address,
 	 * because we use it to identify loopback lacpdus in receive.
 	 */
-	ether_addr_copy(lacpdu_header->hdr.h_source, slave->perm_hwaddr);
+	ether_addr_copy(lacpdu_header->hdr.h_source, slave->dev->dev_addr);
 	lacpdu_header->hdr.h_proto = PKT_TYPE_LACPDU;
 
 	lacpdu_header->lacpdu = port->lacpdu;
-- 
2.31.1