lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230518121426.GJ404509@google.com> Date: Thu, 18 May 2023 13:14:26 +0100 From: Lee Jones <lee@...nel.org> To: Hans de Goede <hdegoede@...hat.com> Cc: Pavel Machek <pavel@....cz>, Jacek Anaszewski <jacek.anaszewski@...il.com>, Sebastian Reichel <sre@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Michael Grzeschik <m.grzeschik@...gutronix.de>, Johannes Berg <johannes@...solutions.net>, Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...filter.org>, linux-leds@...r.kernel.org, linux-pm@...r.kernel.org, linux-usb@...r.kernel.org, netdev@...r.kernel.org, netfilter-devel@...r.kernel.org, coreteam@...filter.org, Yauhen Kharuzhy <jekhor@...il.com> Subject: Re: [PATCH RESEND 4/4] leds: Clear LED_INIT_DEFAULT_TRIGGER when clearing current trigger On Wed, 10 May 2023, Hans de Goede wrote: > Not all triggers use LED_INIT_DEFAULT_TRIGGER, which means that it > will not get cleared when the default trigger is a trigger which > does not use it such as "default-on". > > If the default trigger then later gets replaced by a trigger which > does check LED_INIT_DEFAULT_TRIGGER, such as "timer" then that trigger > will behave as if it is the default trigger which it should not do. > > To fix this clear the LED_INIT_DEFAULT_TRIGGER flag when clearing > the current trigger, so that it will not be set for any subsequently > set (non default) triggers. > > Reviewed-by: Jacek Anaszewski <jacek.anaszewski@...il.com> > Tested-by: Yauhen Kharuzhy <jekhor@...il.com> > Signed-off-by: Hans de Goede <hdegoede@...hat.com> > --- > drivers/leds/led-triggers.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks -- Lee Jones [李琼斯]
Powered by blists - more mailing lists