netdev - Re: [PATCH net 1/7] tls: rx: device: fix checking decryption status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGZHcXD6IPo7ScIm@corigine.com>
Date: Thu, 18 May 2023 17:42:41 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, borisp@...dia.com, john.fastabend@...il.com,
	tariqt@...dia.com, Shai Amiram <samiram@...dia.com>
Subject: Re: [PATCH net 1/7] tls: rx: device: fix checking decryption status

On Tue, May 16, 2023 at 06:50:36PM -0700, Jakub Kicinski wrote:
> skb->len covers the entire skb, including the frag_list.
> In fact we're guaranteed that rxm->full_len <= skb->len,
> so since the change under Fixes we were not checking decrypt
> status of any skb but the first.
> 
> Note that the skb_pagelen() added here may feel a bit costly,
> but it's removed by subsequent fixes, anyway.
> 
> Reported-by: Tariq Toukan <tariqt@...dia.com>
> Fixes: 86b259f6f888 ("tls: rx: device: bound the frag walk")
> Tested-by: Shai Amiram <samiram@...dia.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <simon.horman@...igine.com>