netdev - Re: [PATCH net 3/7] tls: rx: strp: force mixed decrypted records into copy mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGZHmVq5vZw1yfcB@corigine.com>
Date: Thu, 18 May 2023 17:43:21 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, borisp@...dia.com, john.fastabend@...il.com,
	tariqt@...dia.com, Shai Amiram <samiram@...dia.com>
Subject: Re: [PATCH net 3/7] tls: rx: strp: force mixed decrypted records
 into copy mode

On Tue, May 16, 2023 at 06:50:38PM -0700, Jakub Kicinski wrote:
> If a record is partially decrypted we'll have to CoW it, anyway,
> so go into copy mode and allocate a writable skb right away.
> 
> This will make subsequent fix simpler because we won't have to
> teach tls_strp_msg_make_copy() how to copy skbs while preserving
> decrypt status.

Reviewed-by: Simon Horman <simon.horman@...igine.com>