netdev - Re: [PATCH net] net: fec: remove useless fec_enet_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGZduVeDx9TvlToT@corigine.com>
Date: Thu, 18 May 2023 19:17:45 +0200
From: Simon Horman <simon.horman@...igine.com>
To: wei.fang@....com
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, Frank.Li@...escale.com, shenwei.wang@....com,
	xiaoning.wang@....com, netdev@...r.kernel.org, linux-imx@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: fec: remove useless fec_enet_reset_skb()

On Thu, May 18, 2023 at 09:00:16PM +0800, wei.fang@....com wrote:
> From: Wei Fang <wei.fang@....com>
> 
> This patch is a cleanup for fec driver. The fec_enet_reset_skb()
> is used to free skb buffers for tx queues and is only invoked in
> fec_restart(). However, fec_enet_bd_init() also resets skb buffers
> and is invoked in fec_restart() too. So fec_enet_reset_skb() is
> redundant and useless.
> 
> Fixes: 59d0f7465644 ("net: fec: init multi queue date structure")
> Signed-off-by: Wei Fang <wei.fang@....com>

Hi Wei Fang,

this change looks fine to me.
But it feels much more like a cleanup than a fix to me:
what user-visible problem is it fixing?

If so, I suggest targeting against net-next without the fixes tag.