netdev - RE: [PATCH net] net: fec: remove useless fec_enet_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 19 May 2023 01:26:03 +0000
From: Wei Fang <wei.fang@....com>
To: Simon Horman <simon.horman@...igine.com>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "Frank.Li@...escale.com"
	<Frank.Li@...escale.com>, Shenwei Wang <shenwei.wang@....com>, Clark Wang
	<xiaoning.wang@....com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	dl-linux-imx <linux-imx@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net] net: fec: remove useless fec_enet_reset_skb()

> -----Original Message-----
> From: Simon Horman <simon.horman@...igine.com>
> Sent: 2023年5月19日 1:18
> To: Wei Fang <wei.fang@....com>
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; Frank.Li@...escale.com; Shenwei Wang
> <shenwei.wang@....com>; Clark Wang <xiaoning.wang@....com>;
> netdev@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net] net: fec: remove useless fec_enet_reset_skb()
> 
> On Thu, May 18, 2023 at 09:00:16PM +0800, wei.fang@....com wrote:
> > From: Wei Fang <wei.fang@....com>
> >
> > This patch is a cleanup for fec driver. The fec_enet_reset_skb() is
> > used to free skb buffers for tx queues and is only invoked in
> > fec_restart(). However, fec_enet_bd_init() also resets skb buffers and
> > is invoked in fec_restart() too. So fec_enet_reset_skb() is redundant
> > and useless.
> >
> > Fixes: 59d0f7465644 ("net: fec: init multi queue date structure")
> > Signed-off-by: Wei Fang <wei.fang@....com>
> 
> Hi Wei Fang,
> 
> this change looks fine to me.
> But it feels much more like a cleanup than a fix to me:
> what user-visible problem is it fixing?
> 
There is no user-visible problem, just a cleanup.

> If so, I suggest targeting against net-next without the fixes tag.
Okay, I'll change the tree tag. Thank you!