lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230522163706.51863-1-kuniyu@amazon.com> Date: Mon, 22 May 2023 09:37:06 -0700 From: Kuniyuki Iwashima <kuniyu@...zon.com> To: <dario.binacchi@...rulasolutions.com> CC: <mkubecek@...e.cz>, <netdev@...r.kernel.org>, <sudheer.mogilappagari@...el.com>, <kuniyu@...zon.com> Subject: Re: [PATCH ethtool 1/1] netlink/rss: move variable declaration out of the for loop From: Dario Binacchi <dario.binacchi@...rulasolutions.com> Date: Mon, 22 May 2023 18:17:10 +0200 > The patch fixes this compilation error: > > netlink/rss.c: In function 'rss_reply_cb': > netlink/rss.c:166:3: error: 'for' loop initial declarations are only allowed in C99 mode > for (unsigned int i = 0; i < get_count(hash_funcs); i++) { > ^ > netlink/rss.c:166:3: note: use option -std=c99 or -std=gnu99 to compile your code > > The project doesn't really need a C99 compiler, so let's move the variable > declaration outside the for loop. > > Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com> > --- > netlink/rss.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/netlink/rss.c b/netlink/rss.c > index 4ad6065ef698..a4a72e83fcf0 100644 > --- a/netlink/rss.c > +++ b/netlink/rss.c > @@ -92,7 +92,7 @@ int rss_reply_cb(const struct nlmsghdr *nlhdr, void *data) > u8 *hkey = NULL; > bool silent; > int err_ret; > - int ret; > + int i, ret; 'i' was 'unsigned int' and get_count() returns unsigned int. > > silent = nlctx->is_dump || nlctx->is_monitor; > err_ret = silent ? MNL_CB_OK : MNL_CB_ERROR; > @@ -163,7 +163,7 @@ int rss_reply_cb(const struct nlmsghdr *nlhdr, void *data) > printf(" Operation not supported\n"); > return 0; > } > - for (unsigned int i = 0; i < get_count(hash_funcs); i++) { > + for (i = 0; i < get_count(hash_funcs); i++) { > printf(" %s: %s\n", get_string(hash_funcs, i), > (rss_hfunc & (1 << i)) ? "on" : "off"); > } > -- > 2.32.0
Powered by blists - more mailing lists