netdev - Re: [PATCH ethtool 1/1] netlink/rss: move variable declaration out of the for loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 22 May 2023 10:31:34 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: netdev@...r.kernel.org, Michal Kubecek <mkubecek@...e.cz>, Sudheer
 Mogilappagari <sudheer.mogilappagari@...el.com>
Subject: Re: [PATCH ethtool 1/1] netlink/rss: move variable declaration out
 of the for loop

On Mon, 22 May 2023 18:17:10 +0200
Dario Binacchi <dario.binacchi@...rulasolutions.com> wrote:

> The patch fixes this compilation error:
> 
> netlink/rss.c: In function 'rss_reply_cb':
> netlink/rss.c:166:3: error: 'for' loop initial declarations are only allowed in C99 mode
>    for (unsigned int i = 0; i < get_count(hash_funcs); i++) {
>    ^
> netlink/rss.c:166:3: note: use option -std=c99 or -std=gnu99 to compile your code
> 
> The project doesn't really need a C99 compiler, so let's move the variable
> declaration outside the for loop.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>

But you changed the type which will now cause signed/unsigned warnings.