netdev - Re: [PATCH net-next 0/5][pull request] ice: Support 5 layer Tx scheduler topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZG367+pNuYtvHXPh@nanopsycho>
Date: Wed, 24 May 2023 13:54:23 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	michal.wilczynski@...el.com, lukasz.czapnik@...el.com,
	przemyslaw.kitszel@...el.com
Subject: Re: [PATCH net-next 0/5][pull request] ice: Support 5 layer Tx
 scheduler topology

Tue, May 23, 2023 at 07:40:03PM CEST, anthony.l.nguyen@...el.com wrote:
>Michal Wilczynski says:
>
>For performance reasons there is a need to have support for selectable
>Tx scheduler topology. Currently firmware supports only the default
>9-layer and 5-layer topology. This patch series enables switch from
>default to 5-layer topology, if user decides to opt-in.

Why exactly the user cares which FW implementation you use. From what I
see, there is a FW but causing unequal queue distribution in some cases,
you fox this. Why would the user want to alter the behaviour between
fixed and unfixed?


>
>The following are changes since commit b2e3406a38f0f48b1dfb81e5bb73d243ff6af179:
>  octeontx2-pf: Add support for page pool
>and are available in the git repository at:
>  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE
>
>Lukasz Czapnik (1):
>  ice: Add txbalancing devlink param
>
>Michal Wilczynski (2):
>  ice: Enable switching default tx scheduler topology
>  ice: Document txbalancing parameter
>
>Raj Victor (2):
>  ice: Support 5 layer topology
>  ice: Adjust the VSI/Aggregator layers
>
> Documentation/networking/devlink/ice.rst      |  17 ++
> .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  31 +++
> drivers/net/ethernet/intel/ice/ice_common.c   |   6 +
> drivers/net/ethernet/intel/ice/ice_ddp.c      | 200 ++++++++++++++++++
> drivers/net/ethernet/intel/ice/ice_ddp.h      |   7 +-
> drivers/net/ethernet/intel/ice/ice_devlink.c  | 161 +++++++++++++-
> .../net/ethernet/intel/ice/ice_fw_update.c    |   2 +-
> .../net/ethernet/intel/ice/ice_fw_update.h    |   3 +
> drivers/net/ethernet/intel/ice/ice_main.c     | 105 +++++++--
> drivers/net/ethernet/intel/ice/ice_nvm.c      |   2 +-
> drivers/net/ethernet/intel/ice/ice_nvm.h      |   3 +
> drivers/net/ethernet/intel/ice/ice_sched.c    |  34 +--
> drivers/net/ethernet/intel/ice/ice_sched.h    |   3 +
> drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
> 14 files changed, 534 insertions(+), 41 deletions(-)
>
>-- 
>2.38.1
>