netdev - Re: [PATCH net-next 4/5] ice: Add txbalancing devlink param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 May 2023 13:57:18 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Lukasz Czapnik <lukasz.czapnik@...el.com>,
	przemyslaw.kitszel@...el.com,
	Michal Wilczynski <michal.wilczynski@...el.com>,
	Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 4/5] ice: Add txbalancing devlink param

Tue, May 23, 2023 at 07:40:07PM CEST, anthony.l.nguyen@...el.com wrote:
>From: Lukasz Czapnik <lukasz.czapnik@...el.com>
>
>It was observed that Tx performance was inconsistent across all queues
>and/or VSIs and that it was directly connected to existing 9-layer
>topology of the Tx scheduler.
>
>Introduce new private devlink param - txbalance. This parameter gives user
>flexibility to choose the 5-layer transmit scheduler topology which helps
>to smooth out the transmit performance.
>
>Allowed parameter values are true for enabled and false for disabled.
>
>Example usage:
>
>Show:
>devlink dev param show pci/0000:4b:00.0 name txbalancing
>pci/0000:4b:00.0:
>  name txbalancing type driver-specific
>    values:
>      cmode permanent value true

"TXbalancing" sounds quite generic. Also, TXbalancing==false might sound
there is no tx balancing. That is confusing.