netdev - Re: [PATCH net-next] net: fix signedness bug in skb_splice_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <760142.1685107058@warthog.procyon.org.uk>
Date: Fri, 26 May 2023 14:17:38 +0100
From: David Howells <dhowells@...hat.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: dhowells@...hat.com, "David S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
    Paolo Abeni <pabeni@...hat.com>,
    Alexander Duyck <alexanderduyck@...com>,
    Jesper Dangaard Brouer <brouer@...hat.com>,
    Pavel Begunkov <asml.silence@...il.com>,
    Kees Cook <keescook@...omium.org>, Jiri Benc <jbenc@...hat.com>,
    netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: fix signedness bug in skb_splice_from_iter()

Dan Carpenter <dan.carpenter@...aro.org> wrote:

>  	while (iter->count > 0) {
>  		ssize_t space, nr;
> -		size_t off, len;
> +		ssize_t len;
> +		size_t off;

Good point, but why not just move len onto the preceding line?

 	while (iter->count > 0) {
-		ssize_t space, nr;
-		size_t off, len;
+		ssize_t space, nr, len;
+		size_t off;

David