netdev - Re: [PATCH net-next] net: fix signedness bug in skb_splice_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <337838b4-e264-4d4a-87c5-548d49efc5b6@kili.mountain>
Date: Fri, 26 May 2023 16:20:12 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: David Howells <dhowells@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alexander Duyck <alexanderduyck@...com>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Pavel Begunkov <asml.silence@...il.com>,
	Kees Cook <keescook@...omium.org>, Jiri Benc <jbenc@...hat.com>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: fix signedness bug in
 skb_splice_from_iter()

On Fri, May 26, 2023 at 02:17:38PM +0100, David Howells wrote:
> Dan Carpenter <dan.carpenter@...aro.org> wrote:
> 
> >  	while (iter->count > 0) {
> >  		ssize_t space, nr;
> > -		size_t off, len;
> > +		ssize_t len;
> > +		size_t off;
> 
> Good point, but why not just move len onto the preceding line?
> 
>  	while (iter->count > 0) {
> -		ssize_t space, nr;
> -		size_t off, len;
> +		ssize_t space, nr, len;
> +		size_t off;

Sure.  Will do.

regards,
dan carpenter