netdev - Re: [PATCH net] af_packet: do not use READ_ONCE() in packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-Jynh-wBDDFUVUsZ9yv4KMjY6tXSytF5sF=aqfEqTvF9w@mail.gmail.com>
Date: Fri, 26 May 2023 12:09:04 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com, 
	Kuniyuki Iwashima <kuniyu@...zon.com>, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] af_packet: do not use READ_ONCE() in packet_bind()

On Fri, May 26, 2023 at 11:43 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> A recent patch added READ_ONCE() in packet_bind() and packet_bind_spkt()
>
> This is better handled by reading pkt_sk(sk)->num later
> in packet_do_bind() while appropriate lock is held.
>
> READ_ONCE() in writers are often an evidence of something being wrong.
>
> Fixes: 822b5a1c17df ("af_packet: Fix data-races of pkt_sk(sk)->num.")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Kuniyuki Iwashima <kuniyu@...zon.com>
> Cc: Willem de Bruijn <willemb@...gle.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Thanks for catching this Eric.