netdev - Re: [PATCH net-next v2] net: fix signedness bug in skb_splice_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHDZ+G51wKK3/XMi@nanopsycho>
Date: Fri, 26 May 2023 18:10:32 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: David Howells <dhowells@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alexander Duyck <alexanderduyck@...com>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Pavel Begunkov <asml.silence@...il.com>,
	Kees Cook <keescook@...omium.org>, Jiri Benc <jbenc@...hat.com>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: fix signedness bug in
 skb_splice_from_iter()

Fri, May 26, 2023 at 03:39:15PM CEST, dan.carpenter@...aro.org wrote:
>The "len" variable needs to be signed for the error handling to work
>correctly.
>
>Fixes: 2e910b95329c ("net: Add a function to splice pages into an skbuff for MSG_SPLICE_PAGES")
>Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>