netdev - Re: [dhowells-fs:sendpage-1] [tcp] 77f5a42b2d: netperf.Throughput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 26 May 2023 09:51:11 +0100
From: David Howells <dhowells@...hat.com>
To: kernel test robot <oliver.sang@...el.com>
Cc: dhowells@...hat.com, oe-lkp@...ts.linux.dev, lkp@...el.com,
    Eric Dumazet <edumazet@...gle.com>,
    "David S. Miller" <davem@...emloft.net>,
    David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
    Paolo Abeni <pabeni@...hat.com>, Jens Axboe <axboe@...nel.dk>,
    Matthew Wilcox <willy@...radead.org>, netdev@...r.kernel.org,
    ying.huang@...el.com, feng.tang@...el.com, fengwei.yin@...el.com
Subject: Re: [dhowells-fs:sendpage-1] [tcp] 77f5a42b2d: netperf.Throughput_Mbps -14.6% regression

kernel test robot <oliver.sang@...el.com> wrote:

> kernel test robot noticed a -14.6% regression of netperf.Throughput_Mbps on:

Okay, yes, I see something similar on my test machine.  Loopback throughput
drops from ~32Gbit/s to ~26Gbit/s with the Convert do_tcp_sendpages patch.

But! The complete set of patches is not yet fully applied.  If you look at the
two patches I've put on my sendpage-1 branch[1], the first brings the
performance back to where it was before and the second bumps it up to
~43Gbit/s.

However, I don't want to push those into the network tree until support for
MSG_SPLICE_PAGES is added to all the network protocols that support splicing.
I have two more patchsets in the queue and there will be a third before I can
get to that point.

Could you try running this branch through your tests?

Thanks,
David

[1] https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=sendpage-1