netdev - Re: [dhowells-fs:sendpage-1] [tcp] 77f5a42b2d: netperf.Throughput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIA2L76MUoBLyfQf@xsang-OptiPlex-9020>
Date: Wed, 7 Jun 2023 15:47:59 +0800
From: Oliver Sang <oliver.sang@...el.com>
To: David Howells <dhowells@...hat.com>
CC: <oe-lkp@...ts.linux.dev>, <lkp@...el.com>, Eric Dumazet
	<edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, David Ahern
	<dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Jens Axboe <axboe@...nel.dk>, Matthew Wilcox
	<willy@...radead.org>, <netdev@...r.kernel.org>, <ying.huang@...el.com>,
	<feng.tang@...el.com>, <fengwei.yin@...el.com>, <oliver.sang@...el.com>
Subject: Re: [dhowells-fs:sendpage-1] [tcp] 77f5a42b2d:
 netperf.Throughput_Mbps -14.6% regression

hi, David,

On Fri, May 26, 2023 at 09:51:11AM +0100, David Howells wrote:
> kernel test robot <oliver.sang@...el.com> wrote:
> 
> > kernel test robot noticed a -14.6% regression of netperf.Throughput_Mbps on:
> 
> Okay, yes, I see something similar on my test machine.  Loopback throughput
> drops from ~32Gbit/s to ~26Gbit/s with the Convert do_tcp_sendpages patch.
> 
> But! The complete set of patches is not yet fully applied.  If you look at the
> two patches I've put on my sendpage-1 branch[1], the first brings the
> performance back to where it was before and the second bumps it up to
> ~43Gbit/s.
> 
> However, I don't want to push those into the network tree until support for
> MSG_SPLICE_PAGES is added to all the network protocols that support splicing.
> I have two more patchsets in the queue and there will be a third before I can
> get to that point.
> 
> Could you try running this branch through your tests?

sorry for late.

we tested the tip of below branch, as you said, it has better performance
even comparing to the parent of 77f5a42b2d

=========================================================================================
cluster/compiler/cpufreq_governor/ip/kconfig/nr_threads/rootfs/runtime/send_size/tbox_group/test/testcase:
  cs-localhost/gcc-11/performance/ipv4/x86_64-rhel-8.3/50%/debian-11.1-x86_64-20220510.cgz/300s/10K/lkp-icl-2sp2/TCP_SENDFILE/netperf

commit:
  b032c5b94f ("tcp: Support MSG_SPLICE_PAGES")
  77f5a42b2d ("tcp: Convert do_tcp_sendpages() to use MSG_SPLICE_PAGES")
  9d6db9b8db ("splice, net: Reimplement splice_to_socket() to pass multiple bufs to sendmsg()")

b032c5b94fdcfda3 77f5a42b2db3e39c971a7d11f0b 9d6db9b8dbfff4f947a14a85b90
---------------- --------------------------- ---------------------------
         %stddev     %change         %stddev     %change         %stddev
             \          |                \          |                \
     23176           -14.6%      19795           +21.7%      28199        netperf.Throughput_Mbps
   1483319           -14.6%    1266931           +21.7%    1804752        netperf.Throughput_total_Mbps

if you need more tests or more data, please let us know.

BTW, we noticed the reported commit has a new commit-id and now is in linux-next/master
  c5c37af6ecad95 ("tcp: Convert do_tcp_sendpages() to use MSG_SPLICE_PAGES")

and we noticed below regression still exists in current linux-next/master:

270a1c3de47e49dd c5c37af6ecad955acad82a440b8
---------------- ---------------------------
         %stddev     %change         %stddev
             \          |                \
      5458            -7.8%       5031        netperf.Throughput_Mbps
   1397479            -7.8%    1288167        netperf.Throughput_total_Mbps

since tips of below branch are not in linux-next/master so far. just FYI

> 
> Thanks,
> David
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=sendpage-1
> 
>