netdev - Re: [patch net-next 15/15] devlink: save devlink_port_ops into a variable in devlink_port_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHBzk9qVqM4lq2Jf@nanopsycho>
Date: Fri, 26 May 2023 10:53:39 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
	edumazet@...gle.com, leon@...nel.org, saeedm@...dia.com,
	moshe@...dia.com, jesse.brandeburg@...el.com,
	anthony.l.nguyen@...el.com, tariqt@...dia.com, idosch@...dia.com,
	petrm@...dia.com, simon.horman@...igine.com, ecree.xilinx@...il.com,
	habetsm.xilinx@...il.com, michal.wilczynski@...el.com,
	jacob.e.keller@...el.com
Subject: Re: [patch net-next 15/15] devlink: save devlink_port_ops into a
 variable in devlink_port_function_validate()

Thu, May 25, 2023 at 05:29:33PM CEST, kuba@...nel.org wrote:
>On Thu, 25 May 2023 07:58:09 +0200 Jiri Pirko wrote:
>> >I was kinda expected last patch will remove the !ops checks.
>> >Another series comes after this to convert more drivers?  
>> 
>> Well, there are still drivers that don't use the port at all ops. I can
>> have them register with empty struct if you like, no strong opinition. I
>> can do that as follow-up (this set has 15 patches already anyway). Let
>> me know.
>
>Hm. Or maybe we can hook in an empty ops struct in the core when driver
>passes NULL? No strong preference.

Okay, will check, thx!