lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZHXTuejpG6OfipUw@surfacebook> Date: Tue, 30 May 2023 13:45:13 +0300 From: andy.shevchenko@...il.com To: Jiawen Wu <jiawenwu@...stnetic.com> Cc: 'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>, 'Hans de Goede' <hdegoede@...hat.com>, netdev@...r.kernel.org, jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com, jsd@...ihalf.com, Jose.Abreu@...opsys.com, andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk, linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org, mengyuanlou@...-swift.com, 'Piotr Raczynski' <piotr.raczynski@...el.com> Subject: Re: [PATCH net-next v9 1/9] net: txgbe: Add software nodes to support phylink Tue, May 30, 2023 at 02:11:08PM +0800, Jiawen Wu kirjoitti: > On Saturday, May 27, 2023 4:44 PM, Andy Shevchenko wrote: > > On Wed, May 24, 2023 at 05:17:14PM +0800, Jiawen Wu wrote: ... > > > +int txgbe_init_phy(struct txgbe *txgbe) > > > +{ > > > + int ret; > > > + > > > + ret = txgbe_swnodes_register(txgbe); > > > + if (ret) { > > > + wx_err(txgbe->wx, "failed to register software nodes\n"); > > > > > + return ret; > > > + } > > > + > > > + return 0; > > > > These 4 lines can be as simple as > > > > return ret; > > This function is going to be extended with later patches, is it necessary to > simply it here? Nope, thank you for elaboration. > > > +} -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists