netdev - Re: [PATCH v1 net-next 02/14] udplite: Retire UDP-Lite for IPv6.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHXzlz94VL+Y72PR@corigine.com>
Date: Tue, 30 May 2023 15:01:11 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	David Ahern <dsahern@...nel.org>,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 02/14] udplite: Retire UDP-Lite for IPv6.

On Mon, May 29, 2023 at 06:03:36PM -0700, Kuniyuki Iwashima wrote:
> We no longer support IPPROTO_UDPLITE for AF_INET6.
> 
> This commit removes udplite.c and udp_impl.h under net/ipv6 and makes
> some functions static that UDP shared.
> 
> Note that udplite.h is included in udp.c temporarily not to introduce
> breakage, but we will remove it later with dead code.
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

...

> diff --git a/net/ipv6/udp_impl.h b/net/ipv6/udp_impl.h
> deleted file mode 100644
> index 0590f566379d..000000000000
> --- a/net/ipv6/udp_impl.h
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _UDP6_IMPL_H
> -#define _UDP6_IMPL_H
> -#include <net/udp.h>
> -#include <net/udplite.h>
> -#include <net/protocol.h>
> -#include <net/addrconf.h>
> -#include <net/inet_common.h>
> -#include <net/transp_v6.h>
> -
> -int __udp6_lib_rcv(struct sk_buff *, struct udp_table *, int);
> -int __udp6_lib_err(struct sk_buff *, struct inet6_skb_parm *, u8, u8, int,
> -		   __be32, struct udp_table *);
> -
> -int udpv6_init_sock(struct sock *sk);
> -int udp_v6_get_port(struct sock *sk, unsigned short snum);
> -void udp_v6_rehash(struct sock *sk);
> -
> -int udpv6_getsockopt(struct sock *sk, int level, int optname,
> -		     char __user *optval, int __user *optlen);
> -int udpv6_setsockopt(struct sock *sk, int level, int optname, sockptr_t optval,
> -		     unsigned int optlen);
> -int udpv6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len);
> -int udpv6_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, int flags,
> -		  int *addr_len);

clang-16 with W=1 complains that:

 +net/ipv6/udp.c:341:5: warning: no previous prototype for 'udpv6_recvmsg' [-Wmissing-prototypes]
 +  341 | int udpv6_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
 +      |     ^~~~~~~~~~~~~
 +net/ipv6/udp.c:1335:5: warning: no previous prototype for 'udpv6_sendmsg' [-Wmissing-prototypes]
 + 1335 | int udpv6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
 +      |     ^~~~~~~~~~~~~

Likewise it has similar complains about ipv4 in a subsequent patch.

> -void udpv6_destroy_sock(struct sock *sk);
> -
> -#ifdef CONFIG_PROC_FS
> -int udp6_seq_show(struct seq_file *seq, void *v);
> -#endif
> -#endif	/* _UDP6_IMPL_H */

...