lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZHYHCuAy8txERBNR@corigine.com> Date: Tue, 30 May 2023 16:24:10 +0200 From: Simon Horman <simon.horman@...igine.com> To: Kuniyuki Iwashima <kuniyu@...zon.com> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Willem de Bruijn <willemdebruijn.kernel@...il.com>, Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org Subject: Re: [PATCH v1 net-next 05/14] udp: Remove UDP-Lite SNMP stats. On Mon, May 29, 2023 at 06:03:39PM -0700, Kuniyuki Iwashima wrote: > We stored UDP-Lite stats in udplite_statistics and udplite_stats_in6 > of struct netns_mib. > > Since UDP and UDP-Lite share code, UDP_INC_STATS() always has to > check if the socket is UDP-Lite. However, we no longer increment > UDP-Lite stats. > > Let's remove the stats and save one protocol test. > > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com> ... > diff --git a/include/net/udp.h b/include/net/udp.h > index bfe62e73552a..d00509873f6f 100644 > --- a/include/net/udp.h > +++ b/include/net/udp.h > @@ -390,37 +390,28 @@ static inline int copy_linear_skb(struct sk_buff *skb, int len, int off, > } > > /* > - * SNMP statistics for UDP and UDP-Lite > + * SNMP statistics for UDP nit: While we are here perhaps the space before the tab can be removed. Otherwise, LGTM. Reviewed-by: Simon Horman <simon.horman@...igine.com>
Powered by blists - more mailing lists