[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <32aa2c0f-e284-4c5e-ba13-a2ea7783c202@lunn.ch>
Date: Tue, 30 May 2023 15:17:48 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Lukasz Majewski <lukma@...x.de>
Cc: Russell King <linux@...linux.org.uk>,
Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [RFC] net: dsa: slave: Advertise correct EEE capabilities at
slave PHY setup
On Tue, May 30, 2023 at 02:26:21PM +0200, Lukasz Majewski wrote:
> One can disable in device tree advertising of EEE capabilities of PHY
> when 'eee-broken-100tx' property is present in DTS.
>
> With DSA switch it also may happen that one would need to disable EEE due
> to some network issues.
Is EEE actually broken in the MAC/PHY combination?
You should not be using this DT option for configuration. It is there
because there is some hardware which is truly broken, and needs EEE
turned off.
If EEE does work, but you need to turn it off because of latency etc,
then please use ethtool.
Andrew,
Powered by blists - more mailing lists